Skip to content

Fix #9051: Add integer dtype check to RandomPosterize #9052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion test/test_transforms_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import torch
import torchvision.ops
import torchvision.transforms.v2 as transforms
from torchvision.transforms.v2 import RandomPosterize

from common_utils import (
assert_equal,
Expand Down Expand Up @@ -6270,4 +6271,20 @@ def test_different_sizes(self, make_input1, make_input2, query):
@pytest.mark.parametrize("query", [transforms.query_size, transforms.query_chw])
def test_no_valid_input(self, query):
with pytest.raises(TypeError, match="No image"):
query(["blah"])
query(["blah"]

@pytest.mark.parametrize("dtype", [torch.float32, torch.bool, torch.complex64])
def test_random_posterize_dtype_error(dtype):
rp = RandomPosterize(bits=3, p=1.0)
tensor = torch.zeros((1, 3, 5, 5), dtype=dtype)
with pytest.raises(TypeError) as excinfo:
rp(tensor)
assert "Number of value bits is only defined for integer dtypes" in str(excinfo.value)


def test_random_posterize_uint8_pass():
rp = RandomPosterize(bits=4, p=1.0)
tensor = torch.randint(0, 255, (1, 3, 5, 5), dtype=torch.uint8)
out = rp(tensor)
assert isinstance(out, torch.Tensor)
assert out.dtype == torch.uint8
18 changes: 17 additions & 1 deletion torchvision/transforms/v2/_color.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,26 @@
from typing import Any, Optional, Union

import torch
from torch import Tensor
from torchvision import transforms as _transforms
from torchvision.transforms.v2 import functional as F, Transform


from ._transform import _RandomApplyTransform
from ._utils import query_chw

def _ensure_integer_dtype(tensor: Tensor) -> None:
"""
Checks that the tensor's dtype is integer.
Throws TypeError for float, complex, bool, etc.
"""
try:
torch.iinfo(tensor.dtype)
except (ValueError, TypeError):
raise TypeError(
f"Number of value bits is only defined for integer dtypes, but got {tensor.dtype}"
)


class Grayscale(Transform):
"""Convert images or videos to grayscale.
Expand Down Expand Up @@ -306,9 +320,11 @@ def __init__(self, bits: int, p: float = 0.5) -> None:
self.bits = bits

def transform(self, inpt: Any, params: dict[str, Any]) -> Any:
# Check that the tensor is integer
if isinstance(inpt, Tensor):
_ensure_integer_dtype(inpt)
return self._call_kernel(F.posterize, inpt, bits=self.bits)


class RandomSolarize(_RandomApplyTransform):
"""Solarize the image or video with a given probability by inverting all pixel
values above a threshold.
Expand Down