-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix: clear wording error in numpy warmup #3558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In the backpropagation section, there was a comment saying the code was computing the gradient of parameters a, b, c, d wrt the loss. This is flipped and causes confusion about the math of backprop.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3558
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @jbaremoney! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Hi @AlannaBurke thanks for the review and approval... It looks like this PR is approved and the CLA check is green, but the required build / pytorch_tutorial_build_manager check is still in an “expected / waiting for status” state. Would you be able to remove the stale label and, when CI is healthy again, either re-run the docs build or merge this when convenient? Thanks again for your help! |
Description
In the backpropagation section, there was a comment saying the code was computing the gradient of parameters a, b, c, d wrt the loss. This is flipped and causes confusion about the math of backprop.
Specifically, the original comment:
has been changed to:
Checklist