-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update hyper params and set seeds #3384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3384
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7f52575 with merge base 06f9c4b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@vmoens Mind taking a look at these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before approving, do you have a learning curve to share before / after these changes?
@@ -91,6 +91,16 @@ | |||
"cpu" | |||
) | |||
|
|||
# set the seeds for reproducibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI, we already doing it in the CI, not sure if it's helpful to do something like that for all users...
May be add a paragraph saying to uncomment those if you want fixed output all the time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good practice to have it being part of the script and I'd keep it here.
It helps when you run it locally - RL is very seed dependent usually
Fixes #3080
Description
CartPole-v1
environment in the DQN tutorial to better match the results shown in the reference image (only the tutorial file is modified).Checklist