Skip to content

fix slurm integration test #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 10, 2024
Merged

fix slurm integration test #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6c33b8c
Update dev-requirements.txt, Add docker-compose
yikaiMeta Aug 26, 2024
159ab2e
Update slurm-local-integration-tests.yaml
yikaiMeta Aug 26, 2024
774a485
Update dev-requirements.txt
yikaiMeta Aug 26, 2024
9511f36
Update slurm-local-integration-tests.yaml
yikaiMeta Aug 26, 2024
6fd0e24
Update dev-requirements.txt
yikaiMeta Aug 26, 2024
b0b14f6
Update slurm-local-integration-tests.yaml
yikaiMeta Aug 27, 2024
f0d7bf2
Update slurmdockerint.sh
yikaiMeta Aug 27, 2024
cfdd677
Update slurmdockerint.sh
yikaiMeta Sep 2, 2024
8b7c78b
Update slurm-local-integration-tests.yaml
yikaiMeta Sep 9, 2024
fe1cfe6
Update slurmdockerint.sh
yikaiMeta Sep 9, 2024
b45350b
Update slurm-local-integration-tests.yaml
yikaiMeta Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/slurm-local-integration-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
set -ex

cd slurm-docker-cluster
docker-compose pull --ignore-pull-failures
docker compose pull --ignore-pull-failures
continue-on-error: true
# cache layers to avoid rebuilding slurm
- uses: satackey/[email protected]
Expand All @@ -48,11 +48,10 @@ jobs:
run: |
set -ex
cd slurm-docker-cluster
IMAGE_TAG=$SLURM_VERSION docker-compose up --detach
IMAGE_TAG=$SLURM_VERSION docker compose up --detach
- name: Install Dependencies
run:
run: |
set -ex

pip install wheel
- name: Run Slurm Integration Tests
run: |
Expand Down
1 change: 1 addition & 0 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ torchtext==0.17.1
torchvision==0.17.1
ts==0.5.1
ray[default]
wheel

# lint (linter versions are managed by lintrunner)
lintrunner
Expand Down
Loading