Skip to content

Add appdef metadata to torchx event #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

zackycao
Copy link
Contributor

Summary: Add appdef metadata to torchx event class. Scuba logs does not get modified yet.

Differential Revision: D61632621

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61632621

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61632621

zackycao added a commit to zackycao/torchx that referenced this pull request Aug 21, 2024
Summary:
Pull Request resolved: pytorch#947

Add appdef metadata to torchx event class. Scuba logs does not get modified yet.

Differential Revision: D61632621
Copy link
Contributor

@andywag andywag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61632621

zackycao added a commit to zackycao/torchx that referenced this pull request Aug 22, 2024
Summary:
Pull Request resolved: pytorch#947

Add appdef metadata to torchx event class. Scuba logs does not get modified yet.
The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc.

Reviewed By: andywag

Differential Revision: D61632621
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61632621

zackycao added a commit to zackycao/torchx that referenced this pull request Aug 22, 2024
Summary:
Pull Request resolved: pytorch#947

Add appdef metadata to torchx event class. Scuba logs does not get modified yet.
The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc.

Reviewed By: andywag

Differential Revision: D61632621
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61632621

zackycao added a commit to zackycao/torchx that referenced this pull request Aug 22, 2024
Summary:
Pull Request resolved: pytorch#947

Add appdef metadata to torchx event class. Scuba logs does not get modified yet.
The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc.

Reviewed By: andywag

Differential Revision: D61632621
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61632621

zackycao added a commit to zackycao/torchx that referenced this pull request Aug 23, 2024
Summary:
Pull Request resolved: pytorch#947

Add appdef metadata to torchx event class. Scuba logs does not get modified yet.
The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc.

Reviewed By: andywag

Differential Revision: D61632621
zackycao added a commit to zackycao/torchx that referenced this pull request Aug 23, 2024
Summary:
Pull Request resolved: pytorch#947

Add appdef metadata to torchx event class. Scuba logs does not get modified yet.
The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc.

Reviewed By: andywag

Differential Revision: D61632621
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61632621

Summary:
Pull Request resolved: pytorch#947

Add appdef metadata to torchx event class. Scuba logs does not get modified yet.
The motivation of adding this is that so far we need to log distributed_ai_stack which is part of the App Metadata into AI Instrumentation framework which can be used for post data process for training jobs of various training stacks, such as MVAI, Pyper, Conda_On_MAST etc.

Reviewed By: andywag

Differential Revision: D61632621
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61632621

@facebook-github-bot facebook-github-bot merged commit bfce4bd into pytorch:main Aug 23, 2024
21 of 24 checks passed
@zackycao zackycao deleted the export-D61632621 branch August 23, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants