Skip to content

Allow using torchx_ env vars to set scheduler params #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024

Conversation

manav-a
Copy link
Contributor

@manav-a manav-a commented May 22, 2024

Summary: Scheduler params currently can only be set through the programmatic API and not through this is not useful for cases like scheduling on mast rc cluster. This diff now lets you do that.

Differential Revision: D57640022

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57640022

manav-a added a commit to manav-a/torchx that referenced this pull request May 22, 2024
Summary:

Scheduler params currently can only be set through the programmatic API and not through this is not useful for cases like scheduling on mast rc cluster. This diff now lets you do that.

Differential Revision: D57640022
@manav-a manav-a force-pushed the export-D57640022 branch from a0626b0 to 5603572 Compare May 22, 2024 23:39
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57640022

manav-a added a commit to manav-a/torchx that referenced this pull request May 23, 2024
Summary:

Scheduler params currently can only be set through the programmatic API and not through this is not useful for cases like scheduling on mast rc cluster. This diff now lets you do that.

Differential Revision: D57640022
@manav-a manav-a force-pushed the export-D57640022 branch from 5603572 to 63584c1 Compare May 23, 2024 01:23
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57640022

manav-a added a commit to manav-a/torchx that referenced this pull request May 23, 2024
Summary:

Scheduler params currently can only be set through the programmatic API and not through this is not useful for cases like scheduling on mast rc cluster. This diff now lets you do that.

Differential Revision: D57640022
@manav-a manav-a force-pushed the export-D57640022 branch from 63584c1 to 6f3af08 Compare May 23, 2024 01:24
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57640022

Copy link
Contributor

@andywag andywag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

manav-a added a commit to manav-a/torchx that referenced this pull request May 23, 2024
Summary:

Scheduler params currently can only be set through the programmatic API and not through this is not useful for cases like scheduling on mast rc cluster. This diff now lets you do that.

Reviewed By: andywag

Differential Revision: D57640022
@manav-a manav-a force-pushed the export-D57640022 branch from 6f3af08 to c75ea29 Compare May 23, 2024 23:13
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57640022

Summary:

Scheduler params currently can only be set through the programmatic API and not through this is not useful for cases like scheduling on mast rc cluster. This diff now lets you do that.

Reviewed By: andywag

Differential Revision: D57640022
@manav-a manav-a force-pushed the export-D57640022 branch from c75ea29 to b989624 Compare May 23, 2024 23:14
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57640022

@manav-a manav-a merged commit d3393fc into pytorch:main May 24, 2024
22 of 24 checks passed
@manav-a manav-a deleted the export-D57640022 branch May 24, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants