(6/n - non-xlformers conda-on-mast mvp)(torchx/runner) Create //torchx/runner:lib_core with no plugin bundling #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x/runner:lib_core with no plugin bundling Summary: See details in [torchx-lite](https://docs.google.com/document/d/1Y_DzoRMAKhqbzE2LQDb7k3H5R-4PnkYdA9R4YLLFLk4/edit?tab=t.0#heading=h.unqedx38434n) doc. Creates a pure core library target for `torchx.runner` called `//torchx/runner:lib_core`. Similar to D77394064 which creates `//torchx/schedulers:lib_core` NOTE: I added a `autodeps_redirect` to `//torchx/runner:lib` from `:lib_core`. I've noticed that autodeps honors this in some cases but not in others (read IMPORTANT note below if you are finding that autodeps is removing `:lib` in favor of `:lib_core`) IMPORTANT: If you wind up here because autodeps is removing `//torchx/runner:lib` in favor of `//torchx/runner:lib_core`, you have two options (see below). OPTION 2 is preferred since you'll only pull in what you need (not the entire universe of plugins). OPTION 1. Add `# manual` tag to the existing `//torchx/runner:lib` ``` ... deps = [ "//torchx/runner:lib_core", # <-- autodeps will still add this (which is OK) "//torchx/runner:lib", # manual ... ] ... ``` OPTION 2: Accept the swap to `//torchx/runner:lib_core` and add any plugins that you need with `# manual` ``` ... deps = [ "//torchx/runner:lib_core", "//torchx/schedulers/fb:mast_scheduler", # manual (mast scheduler plugin) ... ] ... ``` Reviewed By: highker Differential Revision: D77400710
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77400710 |
d4l3k
approved these changes
Jun 28, 2025
| **get_scheduler_factories(), | ||
| **( | ||
| get_scheduler_factories( | ||
| group="torchx.schedulers.orchestrator", skip_defaults=True |
There was a problem hiding this comment.
is this a regression? or this isn't used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See details in torchx-lite doc.
Creates a pure core library target for
torchx.runnercalled//torchx/runner:lib_core.Similar to D77394064 which creates
//torchx/schedulers:lib_coreNOTE: I added a
autodeps_redirectto//torchx/runner:libfrom:lib_core. I've noticed that autodeps honors this in some cases but not in others (read IMPORTANT note below if you are finding that autodeps is removing:libin favor of:lib_core)IMPORTANT: If you wind up here because autodeps is removing
//torchx/runner:libin favor of//torchx/runner:lib_core, you have two options (see below). OPTION 2 is preferred since you'll only pull in what you need (not the entire universe of plugins).OPTION 1. Add
# manualtag to the existing//torchx/runner:libOPTION 2:
Accept the swap to
//torchx/runner:lib_coreand add any plugins that you need with# manualReviewed By: highker
Differential Revision: D77400710