Skip to content

[config] Reject unknown pipeline_parallel_schedule names - #4564

Merged
tianyu-l merged 1 commit into
pytorch:mainfrom
YeonwooSung:pr/validate-pp-schedule
Sep 10, 2026
Merged

[config] Reject unknown pipeline_parallel_schedule names#4564
tianyu-l merged 1 commit into
pytorch:mainfrom
YeonwooSung:pr/validate-pp-schedule

Conversation

@YeonwooSung

Copy link
Copy Markdown
Contributor

Summary

parallelism.pipeline_parallel_schedule accepted any string. A typo such as Interleved1F1B only failed when get_schedule_class ran after the model was built.

Validate through the upstream schedule registry at ParallelismConfig init (same idea as compile.components and context_parallel_load_balancer). Named schedules and CSV class names (PipelineScheduleMulti, etc.) still work. Unknown names fail even when PP is disabled.

Test plan

  • pytest tests/unit_tests/cpu/test_parallelism_config.py (13 passed)
  • Default 1F1B, Interleaved1F1B, and PipelineScheduleMulti accepted
  • foo, Interleved1F1B, and "" rejected

Typos were accepted until get_schedule_class ran after model build.
Validate through the upstream schedule registry at config init.
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 10, 2026
Comment thread torchtitan/config/configs.py
Comment thread torchtitan/config/configs.py
@tianyu-l
tianyu-l merged commit ca8c707 into pytorch:main Sep 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants