[config] Reject unknown pipeline_parallel_schedule names - #4564
Merged
Conversation
Typos were accepted until get_schedule_class ran after model build. Validate through the upstream schedule registry at config init.
YeonwooSung
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
September 10, 2026 03:03
tianyu-l
reviewed
Sep 10, 2026
tianyu-l
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parallelism.pipeline_parallel_scheduleaccepted any string. A typo such asInterleved1F1Bonly failed whenget_schedule_classran after the model was built.Validate through the upstream schedule registry at
ParallelismConfiginit (same idea ascompile.componentsandcontext_parallel_load_balancer). Named schedules and CSV class names (PipelineScheduleMulti, etc.) still work. Unknown names fail even when PP is disabled.Test plan
pytest tests/unit_tests/cpu/test_parallelism_config.py(13 passed)1F1B,Interleaved1F1B, andPipelineScheduleMultiacceptedfoo,Interleved1F1B, and""rejected