Ulysses-SP WO A2A SAC fix - #4553
Draft
AlbedoWang wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The row-sharded WO-to-reduce-scatter path already saves its logical output through the collective policy. The Ulysses-SP A2A-to-WO path did not have an equivalent save boundary, so backward recomputed one A2A and one WO per transformer layer.
Validation
Known issue
Strict bitwise parity between patched and unpatched fresh runs did not pass. The step-2 relative differences were 2.94e-5 for loss and 1.29e-4 for grad norm, so the change remains draft while this numerical drift is investigated.