Make fused grouped-expert projection the default - #4552
Open
anijain2305 wants to merge 6 commits into
Open
Conversation
anijain2305
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
September 9, 2026 20:53
meta-cla
Bot
added
the
CLA Signed
This was referenced Sep 9, 2026
submartingales
pushed a commit
to botcanlearn/torchtitan-upstream
that referenced
this pull request
Sep 9, 2026
ghstack-source-id: 68bc79b Pull-Request: pytorch/torchtitan#4552
tianyu-l
reviewed
Sep 10, 2026
| self.linear_beta = config.linear_beta | ||
|
|
||
| def forward( | ||
| def _activation( |
Contributor
There was a problem hiding this comment.
commented in the linear PR
| class GroupedExperts(Module): | ||
| """SwiGLU experts with one physical interleaved gate-up parameter. | ||
|
|
||
| ``w13`` has shape ``(E, F, 2, D)`` and is flattened to ``(E, 2F, D)`` for |
Contributor
There was a problem hiding this comment.
why don't we define w13 as (E, 2F, D) as in e.g. FusedQKV https://github.com/pytorch/torchtitan/blob/main/torchtitan/models/common/config_utils.py#L244
| return init | ||
|
|
||
|
|
||
| def _fuse_grouped_experts_param_init(param_init: dict | None) -> dict | None: |
Contributor
There was a problem hiding this comment.
can be put together with https://github.com/pytorch/torchtitan/blob/main/torchtitan/models/common/config_utils.py#L109
In some sense, this is not part of core torchtitan. Users can do whatever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):