-
Notifications
You must be signed in to change notification settings - Fork 528
update matrix filter to exclude cu129 which fbgemm currently doesn't support #3103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D76823583 |
This pull request was exported from Phabricator. Differential Revision: D76823583 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Jun 17, 2025
…support (pytorch#3103) Summary: Pull Request resolved: pytorch#3103 # context * pytorch infra bumps the cuda version to have cu129 appears in the matrix * currently fbgemm only supports up to cu128, which causes cu129 build linux wheels failed on github {F1979407457} * this diff update the filter.py to exclude cu129 Differential Revision: D76823583
850c016
to
96aae0a
Compare
This pull request was exported from Phabricator. Differential Revision: D76823583 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Jun 17, 2025
…support (pytorch#3103) Summary: Pull Request resolved: pytorch#3103 # context * pytorch infra bumps the cuda version to have cu129 appears in the matrix * currently fbgemm only supports up to cu128, which causes cu129 build linux wheels failed on github {F1979407457} * this diff update the filter.py to exclude cu129 Differential Revision: D76823583
96aae0a
to
bc04fe6
Compare
This pull request was exported from Phabricator. Differential Revision: D76823583 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Jun 17, 2025
…support (pytorch#3103) Summary: Pull Request resolved: pytorch#3103 # context * pytorch infra bumps the cuda version to have cu129 appears in the matrix * currently fbgemm only supports up to cu128, which causes cu129 build linux wheels failed on github {F1979407457} * this diff update the filter.py to exclude cu129 Reviewed By: spmex Differential Revision: D76823583
bc04fe6
to
35cbf50
Compare
…support (pytorch#3103) Summary: Pull Request resolved: pytorch#3103 # context * pytorch infra bumps the cuda version to have cu129 appears in the matrix * currently fbgemm only supports up to cu128, which causes cu129 build linux wheels failed on github {F1979407457} * this diff update the filter.py to exclude cu129 Reviewed By: spmex Differential Revision: D76823583
This pull request was exported from Phabricator. Differential Revision: D76823583 |
35cbf50
to
6229dd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
{F1979407457}
Rollback Plan:
Differential Revision: D76823583