Fix optimizer check edge case #3058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76203188 |
Summary: There's an edge case for detecting an optimizer - where no optimizer is applied during backwards, but the compute kernel is fused, so techncially an EBC.optimizer would be created. In this case for dynamic sharding, we still don't need to store any optimizers - I've added the condition to properly check for optimizers to pass the unit test. Differential Revision: D76203188
aporialiao
force-pushed
the
export-D76203188
branch
from
312b81f to
b024677
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76203188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There's an edge case for detecting an optimizer - where no optimizer is applied during backwards, but the compute kernel is fused, so techncially an EBC.optimizer would be created.
In this case for dynamic sharding, we still don't need to store any optimizers - I've added the condition to properly check for optimizers to pass the unit test.
Differential Revision: D76203188