Back out "Add new argument for sharding type" #3022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Rolling back the new `sharding_type` param. Other sharding types do not seem to work properly with the current `shard_quant_model` logic. Instead we are making changes to allow user to provide their own sharding plan for other sharding types (e.g. column-wise sharding). Original commit changeset: bebefd06f38b Original Phabricator Diff: D73540534 Differential Revision: D75727458
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75727458 |
jd7-tr
added a commit
to jd7-tr/torchrec
that referenced
this pull request
Jun 2, 2025
Summary: Rolling back the new `sharding_type` param. Other sharding types do not seem to work properly with the current `shard_quant_model` logic. Instead we are making changes to allow user to provide their own sharding plan for other sharding types (e.g. column-wise sharding). Original commit changeset: bebefd06f38b Original Phabricator Diff: D73540534 Differential Revision: D75727458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Rolling back the new
sharding_typeparam. Other sharding types do not seem to work properly with the currentshard_quant_modellogic. Instead we are making changes to allow user to provide their own sharding plan for other sharding types (e.g. column-wise sharding).Original commit changeset: bebefd06f38b
Original Phabricator Diff: D73540534
Differential Revision: D75727458