Skip to content

[fix] Fix error in Audio Decoder example #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

Conversation

dhunstack
Copy link
Contributor

@dhunstack dhunstack commented Jun 23, 2025

This commit fixes the incorrect text in Custom sample rate section of the Decoding audio streams with AudioDecoder example, as described in issue #738

This commit fixes the incorrect text in `Custom sample rate` section of the
`Decoding audio streams with AudioDecoder` example, as described in
issue `pytorch#738`

Signed-off-by: Anmol Mishra <[email protected]>
@facebook-github-bot
Copy link
Contributor

Hi @dhunstack!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 23, 2025
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and for the PR @dhunstack . I slightly modified your changes to not include absolute number of samples, as those may change if we ever modify the input file.
I retained your point noting that the audio may not sound exactly the same as well.

@NicolasHug NicolasHug merged commit b970bda into pytorch:main Jun 23, 2025
41 of 44 checks passed
Dan-Flores pushed a commit to Dan-Flores/torchcodec that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants