dynamo + torchdeploy bug #265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
I ran into a few bugs when trying to use deploy + dynamo. This PR adds some torchdynamo unit tests to create a minimal repro for these bugs. So far there are 2 bugs 1. Outputs of using dynamo + torchscript + deploy is inconsistent with using just torchscript. 2. Multithreading models which use dynamo run into errors with prims. The output of building and running `test_deploy_compat.cpp` (which contain single and multithreaded dynamo+torchscript+deploy tests using resnet) are [here](https://pastebin.com/vZxNsFJj). One can run these tests again by running ``` cd multipy python multipy/runtime/example/generate_examples.py python -m pip install -e . ./multipy/runtime/build/test_deploy_compat ``` [ghstack-poisoned]
I ran into a few bugs when trying to use deploy + dynamo. This PR adds some torchdynamo unit tests to create a minimal repro for these bugs. So far there are 2 bugs 1. Outputs of using dynamo + torchscript + deploy is inconsistent with using just torchscript. 2. Multithreading models which use dynamo run into errors with prims. The output of building and running `test_deploy_compat.cpp` (which contain single and multithreaded dynamo+torchscript+deploy tests using resnet) are [here](https://pastebin.com/vZxNsFJj). One can run these tests again by running ``` cd multipy python multipy/runtime/example/generate_examples.py python -m pip install -e . ./multipy/runtime/build/test_deploy_compat ``` [ghstack-poisoned]
|
@PaliC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I ran into a few bugs when trying to use deploy + dynamo. This PR adds some torchdynamo unit tests to create a minimal repro for these bugs. So far there are 2 bugs
The output of building and running
test_deploy_compat.cpp(which contain single and multithreaded dynamo+torchscript+deploy tests using resnet) are here.One can run these tests again by running
Differential Revision: D41349350