Skip to content
This repository was archived by the owner on Jul 1, 2025. It is now read-only.

Remove using namespace from header in glow/glow/include/glow/Base/SliceRange.h +1 #6172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove using namespace from header in glow/glow/include/glow/Base/SliceRange.h +1 #6172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions include/glow/Base/SliceRange.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@
#include <unordered_set>
#include <vector>

using namespace glow;
using llvm::cast;
using llvm::dyn_cast;
using llvm::isa;

namespace glow {

/// Dimension range representing a contiguous [start, stop) index interval with
Expand Down
9 changes: 5 additions & 4 deletions tests/unittests/NodeSplittingTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,18 @@ TEST(TestSplitNodeOption, CheckLLVMStyleRTTI) {
SplitNodeOption::SplitNodeKind::SplitNodeByChunkWeights);
std::vector<SplitNodeOption *> orthogonalOpts = {&opt1, &opt2, &opt3, &opt4};
for (auto opt : orthogonalOpts) {
EXPECT_NE(nullptr, dyn_cast<SplitNodeOptionOrthogonal>(opt));
EXPECT_EQ(nullptr, dyn_cast<SplitNodeBySliceRanges>(opt));
EXPECT_NE(nullptr, llvm::dyn_cast<SplitNodeOptionOrthogonal>(opt));
EXPECT_EQ(nullptr, llvm::dyn_cast<SplitNodeBySliceRanges>(opt));
}
// Check non-orthogonal options.
std::vector<SliceRange> sliceRanges = {SliceRange({{0, 1}})};
auto opt5 = SplitNodeBySliceRanges(sliceRanges);
EXPECT_EQ(opt5.getKind(),
SplitNodeOption::SplitNodeKind::SplitNodeBySliceRanges);
SplitNodeOption *nonOrthogonalOpt = &opt5;
EXPECT_EQ(nullptr, dyn_cast<SplitNodeOptionOrthogonal>(nonOrthogonalOpt));
EXPECT_NE(nullptr, dyn_cast<SplitNodeBySliceRanges>(nonOrthogonalOpt));
EXPECT_EQ(nullptr,
llvm::dyn_cast<SplitNodeOptionOrthogonal>(nonOrthogonalOpt));
EXPECT_NE(nullptr, llvm::dyn_cast<SplitNodeBySliceRanges>(nonOrthogonalOpt));
}

/// Test for SplitNodeByNumChunks option.
Expand Down