Gate test xfails on dependency versions - #22658
Conversation
Summary: `arange_fp32_2d_step4` passes with internal `model-converter` 0.9.0 and fails with the 0.10.0 release used on GitHub. Internal glibc compatibility prevents upgrading the converter, so gate the slice xfail on `>=0.10.0` to keep the source synchronized while preserving the correct result in each environment. Keep the marker strict so a future converter release that fixes the bug reports an XPASS and prompts an update to the xfail. Add `xfail_if_version` for PEP 440 specifiers and `xfail_if_dependency_version` for distribution metadata with an optional module `__version__` fallback, including `ethos-u-vela` in Buck. The converter wrapper reads the executable selected by the existing VGF tooling. Missing versions leave normal test behavior intact; unparseable installed versions warn and disable the xfail, while invalid caller specifiers remain errors. Extend `common.parametrize` to accept xfail markers and preserve their `strict` and `raises` options. This follows the revert of D117201127 so the slice change replaces the block already present on GitHub. It supersedes PR pytorch#22083. Both `xplat` and `fbcode` mirrors are updated. Authored with Codex. Differential Revision: D119383772
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22658
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 1 Unclassified FailureAs of commit 1c7ffee with merge base 25f155c ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119383772. |
This PR needs a
|
Summary:
arange_fp32_2d_step4passes with internalmodel-converter0.9.0 and fails with the 0.10.0 release used on GitHub. Internal glibc compatibility prevents upgrading the converter, so gate the slice xfail on>=0.10.0to keep the source synchronized while preserving the correct result in each environment. Keep the marker strict so a future converter release that fixes the bug reports an XPASS and prompts an update to the xfail.Add
xfail_if_versionfor PEP 440 specifiers andxfail_if_dependency_versionfor distribution metadata with an optional module__version__fallback, includingethos-u-velain Buck. The converter wrapper reads the executable selected by the existing VGF tooling. Missing versions leave normal test behavior intact; unparseable installed versions warn and disable the xfail, while invalid caller specifiers remain errors. Extendcommon.parametrizeto accept xfail markers and preserve theirstrictandraisesoptions.This follows the revert of D117201127 so the slice change replaces the block already present on GitHub. It supersedes PR #22083. Both
xplatandfbcodemirrors are updated.Authored with Codex.
Differential Revision: D119383772
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell