Skip to content

Gate test xfails on dependency versions - #22658

Open
rascani wants to merge 1 commit into
pytorch:mainfrom
rascani:export-D119383772
Open

Gate test xfails on dependency versions#22658
rascani wants to merge 1 commit into
pytorch:mainfrom
rascani:export-D119383772

Conversation

@rascani

@rascani rascani commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary:
arange_fp32_2d_step4 passes with internal model-converter 0.9.0 and fails with the 0.10.0 release used on GitHub. Internal glibc compatibility prevents upgrading the converter, so gate the slice xfail on >=0.10.0 to keep the source synchronized while preserving the correct result in each environment. Keep the marker strict so a future converter release that fixes the bug reports an XPASS and prompts an update to the xfail.

Add xfail_if_version for PEP 440 specifiers and xfail_if_dependency_version for distribution metadata with an optional module __version__ fallback, including ethos-u-vela in Buck. The converter wrapper reads the executable selected by the existing VGF tooling. Missing versions leave normal test behavior intact; unparseable installed versions warn and disable the xfail, while invalid caller specifiers remain errors. Extend common.parametrize to accept xfail markers and preserve their strict and raises options.

This follows the revert of D117201127 so the slice change replaces the block already present on GitHub. It supersedes PR #22083. Both xplat and fbcode mirrors are updated.

Authored with Codex.

Differential Revision: D119383772

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Summary:
`arange_fp32_2d_step4` passes with internal `model-converter` 0.9.0 and fails with the 0.10.0 release used on GitHub. Internal glibc compatibility prevents upgrading the converter, so gate the slice xfail on `>=0.10.0` to keep the source synchronized while preserving the correct result in each environment. Keep the marker strict so a future converter release that fixes the bug reports an XPASS and prompts an update to the xfail.

Add `xfail_if_version` for PEP 440 specifiers and `xfail_if_dependency_version` for distribution metadata with an optional module `__version__` fallback, including `ethos-u-vela` in Buck. The converter wrapper reads the executable selected by the existing VGF tooling. Missing versions leave normal test behavior intact; unparseable installed versions warn and disable the xfail, while invalid caller specifiers remain errors. Extend `common.parametrize` to accept xfail markers and preserve their `strict` and `raises` options.

This follows the revert of D117201127 so the slice change replaces the block already present on GitHub. It supersedes PR pytorch#22083. Both `xplat` and `fbcode` mirrors are updated.

Authored with Codex.

Differential Revision: D119383772
@rascani
rascani requested a review from digantdesai as a code owner September 9, 2026 22:11
@pytorch-bot

pytorch-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22658

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 1 Unclassified Failure

As of commit 1c7ffee with merge base 25f155c (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / cpu-test / Resolve CI docker image / resolve (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / hifi-build / hifi4 (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Lint / lintrunner (gh)
    >>> Lint for backends/arm/test/misc/test_version_xfail.py:
  • Lint / lintrunner-mypy (gh)
    >>> Lint for backends/arm/test/ops/mxfp/test_mxfp_linear.py:
  • pull / test-arm-backend-no-driver (test_pytest_ops_no_target) / linux-job (gh)
    test_unparseable_version_warns_without_xfail[4.3.0-29-gd37febc]
  • trunk / test-huggingface-transformers-xnnpack (gemma3-1b|xnnpack|--quantize) / linux-job (gh)
    RuntimeError: Command docker exec -t 4015112bbfee48aa98a5737fd9e6e51bdfd5f904e2fe4514a1640114aa25fbe8 /exec failed with exit code 1

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2026
@meta-codesync

meta-codesync Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119383772.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant