NXP backend: Keep test_cifarnet in the wheel for internal testing. - #22645
NXP backend: Keep test_cifarnet in the wheel for internal testing.#22645MartinPavella wants to merge 1 commit into
test_cifarnet in the wheel for internal testing.#22645Conversation
MartinPavella
added
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22645
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 PendingAs of commit 7523e89 with merge base 5dc1c72 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
|
The internal CI is now passing: https://bamboo3.sw.nxp.com/browse/MLTECE-EXGHSPEC46-JOB1-1 |
| "executorch.examples.models.muse_glimmer.tests.test_mlx_pipeline", | ||
| "executorch.examples.models.muse_glimmer.tests.test_prompt_tokens", | ||
| "executorch.extension.pybindings.test.test_pybindings", | ||
| "executorch.backends.nxp.tests.generic_tests.test_cifarnet", |
There was a problem hiding this comment.
This test now ships in the wheel but both of its conftest files do not. Nothing sets the project dir or the runner path, the kernel imports never run, and the outputs folder is never created. A run from the installed wheel fails before the test starts. Either keep the conftest files with the test, or make the test not need them. If the internal setup already covers all of that, please say so next to the entry.
There was a problem hiding this comment.
Thanks for the suggestions.
I don't really like the idea of adding these workarounds just so we can import from the test_cifarnet module in our internal integration repo. I have decided to go with an internal fix instead, which renders this PR obsolete.
2 participants
Summary
A recent PR prevented unreferenced modules from being included in the wheel. The
test_cifarnetmodule is however referenced in the NXP internal testing infrastructure, so the internal CI was broken.This PR adds an exception, ensuring the
test_cifarnetis included in the wheel.Test plan
N/A
cc @robert-kalmar @JakeStevens @digantdesai @rascani