-
Notifications
You must be signed in to change notification settings - Fork 741
Fix -Wimplicit-const-int-float-conversion error. #15982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hsharma35
wants to merge
1
commit into
pytorch:main
Choose a base branch
from
hsharma35:export-D87882617
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15982
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87882617. |
zonglinpeng
approved these changes
Nov 25, 2025
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 25, 2025
Summary: as titled Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D87882617
msluszniak
reviewed
Nov 25, 2025
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 26, 2025
Summary: as titled Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D87882617
a51a531 to
7c832e3
Compare
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 26, 2025
Summary: as titled Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D87882617
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 26, 2025
Summary: as titled Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D87882617
Summary: as titled Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D87882617
hsharma35
added a commit
to hsharma35/executorch
that referenced
this pull request
Nov 26, 2025
Summary: as titled Reviewed By: skrtskrtfb, zonglinpeng Differential Revision: D87882617
7c832e3 to
f27d18f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: as titled
Reviewed By: skrtskrtfb
Differential Revision: D87882617