Fix Transpose Optimization Bug With non-4D Tensor Input #12520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12520
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 4d7f6b1 with merge base abd6eff ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78357428 |
mcr229
approved these changes
Jul 15, 2025
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Summary: Fixed a bug in the channels last tagged reshape pass, where non-4d inputs were being tagged as contiguous/channels last memory formats, which isn't expected as these formats only apply to 4d tensors. The repro is in N7569847. The fix was completed by checking tensor shape size before tagging input nodes. Reviewed By: mcr229 Differential Revision: D78357428
facebook-github-bot
force-pushed
the
export-D78357428
branch
from
2653477 to
4d7f6b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78357428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fixed a bug in the channels last tagged reshape pass, where non-4d inputs were being tagged as contiguous/channels last memory formats, which isn't expected as these formats only apply to 4d tensors. The repro is in N7569847. The fix was completed by checking tensor shape size before tagging input nodes.
Reviewed By: mcr229
Differential Revision: D78357428