Skip to content

Config object for StaticAttentionIOManager and decoding helper #12379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Config object for StaticAttentionIOManager and decoding helper #12379

merged 1 commit into from
Jul 14, 2025

Conversation

sxu
Copy link
Contributor

@sxu sxu commented Jul 10, 2025

Summary:

  • Group individual config variables into a configuration object.
  • Add a simple decoding helper in preparation for lookahead decoding next.

Differential Revision: D78113341

@sxu sxu requested review from lucylq and jackzhxng as code owners July 10, 2025 23:21
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12379

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 19 Pending

As of commit 070f354 with merge base a374bca (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78113341

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@sxu sxu requested review from billmguo and YIWENX14 July 10, 2025 23:25
@sxu sxu force-pushed the export-D78113341 branch from 972728b to 59eda94 Compare July 11, 2025 16:28
sxu added a commit to sxu/executorch that referenced this pull request Jul 11, 2025
@sxu @facebook-github-bot
Config object for StaticAttentionIOManager and decoding helper (pytor…
59eda94 
…ch#12379)

Summary:

- Group individual config variables into a configuration object.
- Add a simple decoding helper in preparation for lookahead decoding next.

Reviewed By: billmguo

Differential Revision: D78113341
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78113341

sxu added a commit to sxu/executorch that referenced this pull request Jul 11, 2025
@sxu @facebook-github-bot
Config object for StaticAttentionIOManager and decoding helper (pytor…
daef891 
…ch#12379)

Summary:
Pull Request resolved: pytorch#12379

- Group individual config variables into a configuration object.
- Add a simple decoding helper in preparation for lookahead decoding next.

Reviewed By: billmguo

Differential Revision: D78113341
@sxu sxu force-pushed the export-D78113341 branch from 59eda94 to daef891 Compare July 11, 2025 16:34
sxu added a commit to sxu/executorch that referenced this pull request Jul 11, 2025
@sxu @facebook-github-bot
Config object for StaticAttentionIOManager and decoding helper (pytor…
c913763 
…ch#12379)

Summary:

- Group individual config variables into a configuration object.
- Add a simple decoding helper in preparation for lookahead decoding next.

Reviewed By: billmguo

Differential Revision: D78113341
@sxu sxu force-pushed the export-D78113341 branch from daef891 to c913763 Compare July 11, 2025 17:03
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78113341

@sxu @facebook-github-bot
Config object for StaticAttentionIOManager and decoding helper (pytor…
070f354 
…ch#12379)

Summary:

- Group individual config variables into a configuration object.
- Add a simple decoding helper in preparation for lookahead decoding next.

Reviewed By: billmguo

Differential Revision: D78113341
@sxu sxu force-pushed the export-D78113341 branch from c913763 to 070f354 Compare July 14, 2025 15:59
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78113341

@facebook-github-bot facebook-github-bot merged commit bd2f795 into pytorch:main Jul 14, 2025
103 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billmguo billmguo billmguo approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@YIWENX14 YIWENX14 Awaiting requested review from YIWENX14

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sxu @facebook-github-bot @billmguo