-
Notifications
You must be signed in to change notification settings - Fork 617
Expand CoreML CI for model testing #12371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12371
Note: Links to docs will display an error until the docs builds have been completed. ❌ 12 New Failures, 6 Unrelated FailuresAs of commit ec668b3 with merge base f82c2f0 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
119efd1
to
ac71e8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some comments.
This is the recommended anyway, so let's gradually start migrating to strict=False
ac71e8e
to
ec668b3
Compare
We're currently testing periodically in device farm on actual iphones.
However, we should also keep testing on macrunners directly in trunk