-
Notifications
You must be signed in to change notification settings - Fork 620
Run test_models.sh with strict=False flag #12368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is the recommended anyway, so let's gradually start migrating to strict=False
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12368
Note: Links to docs will display an error until the docs builds have been completed. ❌ 10 New Failures, 2 Unrelated FailuresAs of commit c16b645 with merge base a1e3d48 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember (not sure how accurately) but there were some PTE size bloats reported with strict==false
and I am not sure we have a CI to catch that. I think we should validate that and then start embracing this.
cc @GregoryComer - who I think reported this a while back for a quant model.
@digantdesai yea we should probably check that model size isn't bloated. We don't have any CI here that checks for this so right now we would have to do so manually. |
Can we add a CI to make sure it doesn't double or something, just a guard against regressing. |
This is the recommended anyway, so let's gradually start migrating to strict=False