Skip to content

Fix replace view ops pass to not be a hardcoded list #12361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

Fix replace view ops pass to not be a hardcoded list #12361

merged 1 commit into from
Jul 11, 2025

Conversation

JacobSzwejbka
Copy link
Contributor

Summary:
Instead of maintaining a list we can check if its a view op from its property and then surgery out the name and inject _copy.

Issue: #12103

Differential Revision: D78116054

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12361

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c0db862 with merge base 378f062 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78116054

@JacobSzwejbka JacobSzwejbka requested a review from bdhirsh July 10, 2025 20:29
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

bdhirsh
bdhirsh reviewed Jul 10, 2025
View reviewed changes
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 10, 2025
@JacobSzwejbka @facebook-github-bot
Fix replace view ops pass to not be a hardcoded list (pytorch#12361)
fa95615 
Summary:

Instead of maintaining a list we can check if its a view op from its property and then surgery out the name and inject _copy.

Issue: pytorch#12103

Differential Revision: D78116054
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78116054

@JacobSzwejbka @facebook-github-bot
Fix replace view ops pass to not be a hardcoded list (pytorch#12361)
c0db862 
Summary:

Instead of maintaining a list we can check if its a view op from its property and then surgery out the name and inject _copy.

Issue: pytorch#12103

Differential Revision: D78116054
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78116054

@facebook-github-bot facebook-github-bot merged commit 51ea3a6 into pytorch:main Jul 11, 2025
98 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdhirsh bdhirsh bdhirsh left review comments

@GregoryComer GregoryComer GregoryComer approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JacobSzwejbka @facebook-github-bot @GregoryComer @bdhirsh