-
Notifications
You must be signed in to change notification settings - Fork 617
Don't Decompose Hardswish #12360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't Decompose Hardswish #12360
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12360
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 11 Unrelated FailuresAs of commit 15df3d3 with merge base bdbad3f ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D77765129 |
This PR needs a
|
Summary: Investigating MV3, I noticed that hardswish was getting decomposed into many little ops. This become annoying because it injected unnecessary transposes, and also wasn't being quantized. I didn't realize that this was being decomposed. After doing some investigating, it looks like this can greatly improve our MV3 Performance for both Quantized and FP32 models. Some benchmarks here. | | Before Hardwish Decomp | After Hardswish Decomp | Latency Reduction | |----------------|------------------------|------------------------|-------------------| | Macbook (FP32) | [13.3685]((https://www.internalfb.com/phabricator/paste/view/P1859573931)) | [8.451](https://www.internalfb.com/phabricator/paste/view/P1859573328) |36% | | Macbook (QS8) | [16.0361](https://www.internalfb.com/phabricator/paste/view/P1859609658) | [4.914](https://www.internalfb.com/phabricator/paste/view/P1859610252) |69% | | S24 (FP32) | [56.885](https://www.internalfb.com/intern/paste/P1859603500) | [41.9638](https://www.internalfb.com/intern/paste/P1859603738) |26% | | S24 (QS8) | [56.1718](https://www.internalfb.com/intern/paste/P1859615896) | [40.2096](https://www.internalfb.com/intern/paste/P1859615683/) |40% | Reviewed By: cccclai Differential Revision: D77765129
This pull request was exported from Phabricator. Differential Revision: D77765129 |
Summary: Investigating MV3, I noticed that hardswish was getting decomposed into many little ops. This become annoying because it injected unnecessary transposes, and also wasn't being quantized. I didn't realize that this was being decomposed. After doing some investigating, it looks like this can greatly improve our MV3 Performance for both Quantized and FP32 models. Some benchmarks here. | | Before Hardwish Decomp | After Hardswish Decomp | Latency Reduction | |----------------|------------------------|------------------------|-------------------| | Macbook (FP32) | [13.3685]((https://www.internalfb.com/phabricator/paste/view/P1859573931)) | [8.451](https://www.internalfb.com/phabricator/paste/view/P1859573328) |36% | | Macbook (QS8) | [16.0361](https://www.internalfb.com/phabricator/paste/view/P1859609658) | [4.914](https://www.internalfb.com/phabricator/paste/view/P1859610252) |69% | | S24 (FP32) | [56.885](https://www.internalfb.com/intern/paste/P1859603500) | [41.9638](https://www.internalfb.com/intern/paste/P1859603738) |26% | | S24 (QS8) | [56.1718](https://www.internalfb.com/intern/paste/P1859615896) | [40.2096](https://www.internalfb.com/intern/paste/P1859615683/) |40% | Reviewed By: cccclai Differential Revision: D77765129
This pull request was exported from Phabricator. Differential Revision: D77765129 |
Summary:
Investigating MV3, I noticed that hardswish was getting decomposed into many little ops. This become annoying because it injected unnecessary transposes, and also wasn't being quantized. I didn't realize that this was being decomposed. After doing some investigating, it looks like this can greatly improve our MV3 Performance for both Quantized and FP32 models. Some benchmarks here.
Reviewed By: cccclai
Differential Revision: D77765129