-
Notifications
You must be signed in to change notification settings - Fork 618
NXP backend: Add support for 'aten::hardtanh' operator #12339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NXP backend: Add support for 'aten::hardtanh' operator #12339
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12339
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 89cf566 with merge base ec379da ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "module: nxp" "release notes: nxp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a comment about tests.
backends/nxp/tests/ir/converter/node_converter/test_hardtanh_converter.py
Show resolved
Hide resolved
The nxp unit-test is passing but I see other red signals. Can you make sure they are not related and also please rebase? Then we can merge. |
1aad2be
to
5bedf74
Compare
I checked the red-signals and it seems to be unrelated to this PR. |
5bedf74
to
8f1aa1c
Compare
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Tests seems OK.
|
8f1aa1c
to
0d201e0
Compare
Applied the comments. Running the CI. If green, will merge. |
0d201e0
to
89cf566
Compare
Summary
Add operator converter for supported aten.hardtanh variants.
Test plan
Unit tests provided.
cc @digantdesai @JakeStevens @robert-kalmar