Skip to content

NXP backend: Add support for 'aten::hardtanh' operator #12339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StrycekSimon
Copy link
Contributor

@StrycekSimon StrycekSimon commented Jul 10, 2025

Summary

Add operator converter for supported aten.hardtanh variants.

Test plan

Unit tests provided.

cc @digantdesai @JakeStevens @robert-kalmar

Copy link

pytorch-bot bot commented Jul 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12339

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 89cf566 with merge base ec379da (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2025
@StrycekSimon
Copy link
Contributor Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Jul 10, 2025
@StrycekSimon StrycekSimon marked this pull request as ready for review July 10, 2025 15:27
@swolchok swolchok requested a review from digantdesai July 10, 2025 17:10
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a comment about tests.

@digantdesai
Copy link
Contributor

The nxp unit-test is passing but I see other red signals. Can you make sure they are not related and also please rebase? Then we can merge.

@StrycekSimon StrycekSimon force-pushed the upstream/main-nxp/EIEX-367-upstream-aten-hardtanh-operator branch from 1aad2be to 5bedf74 Compare July 14, 2025 12:57
@StrycekSimon
Copy link
Contributor Author

I checked the red-signals and it seems to be unrelated to this PR.

@StrycekSimon StrycekSimon force-pushed the upstream/main-nxp/EIEX-367-upstream-aten-hardtanh-operator branch from 5bedf74 to 8f1aa1c Compare July 15, 2025 11:45
Copy link

pytorch-bot bot commented Jul 15, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@robert-kalmar
Copy link
Collaborator

Tests seems OK.
The failures are infrastructure problems:

@robert-kalmar robert-kalmar force-pushed the upstream/main-nxp/EIEX-367-upstream-aten-hardtanh-operator branch from 8f1aa1c to 0d201e0 Compare July 16, 2025 11:50
@robert-kalmar
Copy link
Collaborator

Applied the comments. Running the CI. If green, will merge.

@robert-kalmar robert-kalmar force-pushed the upstream/main-nxp/EIEX-367-upstream-aten-hardtanh-operator branch from 0d201e0 to 89cf566 Compare July 16, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants