Remove arg index from the get_arg and set_arg of a torch Node #12326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12326
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit f6ae97d with merge base bdbad3f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77976838 |
This PR needs a
|
CaptnJackSparrow
pushed a commit
that referenced
this pull request
Jul 10, 2025
Summary: Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node. Reviewed By: abeakkas Differential Revision: D77976838
CaptnJackSparrow
force-pushed
the
export-D77976838
branch
from
41677a9 to
a38d2e3
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
Summary: Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node. Reviewed By: abeakkas Differential Revision: D77976838
facebook-github-bot
force-pushed
the
export-D77976838
branch
from
a38d2e3 to
ee5ca95
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77976838 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D77976838 |
CaptnJackSparrow
force-pushed
the
export-D77976838
branch
from
ee5ca95 to
d39cc39
Compare
CaptnJackSparrow
pushed a commit
that referenced
this pull request
Jul 10, 2025
Summary: Pull Request resolved: #12326 Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node. Reviewed By: abeakkas Differential Revision: D77976838
abeakkas
approved these changes
Jul 10, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
Summary: Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node. Reviewed By: abeakkas Differential Revision: D77976838
facebook-github-bot
force-pushed
the
export-D77976838
branch
from
d39cc39 to
2a179cd
Compare
CaptnJackSparrow
pushed a commit
that referenced
this pull request
Jul 10, 2025
Summary: Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node. Reviewed By: abeakkas Differential Revision: D77976838
CaptnJackSparrow
force-pushed
the
export-D77976838
branch
from
2a179cd to
22da5af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77976838 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D77976838 |
CaptnJackSparrow
pushed a commit
that referenced
this pull request
Jul 10, 2025
Summary: Pull Request resolved: #12326 Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node. Reviewed By: abeakkas Differential Revision: D77976838
CaptnJackSparrow
force-pushed
the
export-D77976838
branch
from
22da5af to
d043880
Compare
CaptnJackSparrow
pushed a commit
that referenced
this pull request
Jul 10, 2025
Summary: Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node. Reviewed By: abeakkas Differential Revision: D77976838
CaptnJackSparrow
force-pushed
the
export-D77976838
branch
from
d043880 to
2748ed1
Compare
Summary: Pull Request resolved: #12326 Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node. Reviewed By: abeakkas Differential Revision: D77976838
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
Summary: Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node. Reviewed By: abeakkas Differential Revision: D77976838
facebook-github-bot
force-pushed
the
export-D77976838
branch
from
2748ed1 to
6a2909c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77976838 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D77976838 |
CaptnJackSparrow
force-pushed
the
export-D77976838
branch
from
6a2909c to
f6ae97d
Compare
zonglinpeng
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Instead of using the arg index, rely on the normalized kwargs dictionary for a uniform view of a node's arguments. This diff cleans up the get_arg and set_arg api so that callers do not need to additionally keep track of arg indices. This simplifies the calling code and also prevents unnecessary code maintenance in case the op signature changes thereby changing the relative positioning of the args within a node.
Reviewed By: abeakkas
Differential Revision: D77976838