[ET-VK] Using push constants for convolution prepack dispatches. #11306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D74523774](https://our.internmc.facebook.com/intern/diff/D74523774/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11306
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0e9cf7f with merge base af0a246 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
trivedivivek
added a commit
that referenced
this pull request
Jun 3, 2025
Differential Revision: [D74523774](https://our.internmc.facebook.com/intern/diff/D74523774/) ghstack-source-id: 287760412 Pull Request resolved: #11306
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74523774 |
trivedivivek
added
the
release notes: vulkan
nathanaelsee
approved these changes
Jun 4, 2025
…tches." Differential Revision: [D74523774](https://our.internmc.facebook.com/intern/diff/D74523774/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Jun 4, 2025
Pull Request resolved: #11306 This diff switches the `conv2d_prepack_weights`, `conv2d_dw_prepack_weights`, and `conv_transpose2d_prepack_weights` shaders to use push constants instead of uniform buffers for the `sizes` and `original_sizes` variables. ghstack-source-id: 288155883 @exported-using-ghexport Differential Revision: [D74523774](https://our.internmc.facebook.com/intern/diff/D74523774/)
|
This pull request was exported from Phabricator. Differential Revision: D74523774 |
…tches." Differential Revision: [D74523774](https://our.internmc.facebook.com/intern/diff/D74523774/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
Jun 4, 2025
Pull Request resolved: #11306 This diff switches the `conv2d_prepack_weights`, `conv2d_dw_prepack_weights`, and `conv_transpose2d_prepack_weights` shaders to use push constants instead of uniform buffers for the `sizes` and `original_sizes` variables. ghstack-source-id: 288178302 @exported-using-ghexport Differential Revision: [D74523774](https://our.internmc.facebook.com/intern/diff/D74523774/)
|
This pull request was exported from Phabricator. Differential Revision: D74523774 |
facebook-github-bot
merged commit becbac4
into
gh/trivedivivek/110/base
98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
Jun 4, 2025
) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11306 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/110/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/110/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/109/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/110/orig @diff-train-skip-merge Co-authored-by: Vivek Trivedi <[email protected]>
SS-JIA
added a commit
that referenced
this pull request
Jun 6, 2025
…stdout logging ## Changes Some changes to `vulkan_compute_api_test`: * Remove `conv2d_prepack_test`. D74523774 / #11306 recently changed the conv2d prepack shader to use push constants, and since this test uses the "old" vulkan compute API (which doesn't support push constants) the test broke. Operator tests at this point are handled by `compute_graph_op_tests` anyway so just remove this test. * Make it so that verbose logging in `test_to_copy` only occurs in `VULKAN_DEBUG` is defined * Disable `test_etvk_copy_channel_offset_node*` tests, as these tests fail on some platforms (i.e. devGPU, windows, mac) likely due to an error in the implementation of the op. Differential Revision: [D76156109](https://our.internmc.facebook.com/intern/diff/D76156109/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 6, 2025
… compute_api_test + reduce stdout logging" ## Changes Some changes to `vulkan_compute_api_test`: * Remove `conv2d_prepack_test`. D74523774 / #11306 recently changed the conv2d prepack shader to use push constants, and since this test uses the "old" vulkan compute API (which doesn't support push constants) the test broke. Operator tests at this point are handled by `compute_graph_op_tests` anyway so just remove this test. * Make it so that verbose logging in `test_to_copy` only occurs in `VULKAN_DEBUG` is defined * Disable `test_etvk_copy_channel_offset_node*` tests, as these tests fail on some platforms (i.e. devGPU, windows, mac) likely due to an error in the implementation of the op. Differential Revision: [D76156109](https://our.internmc.facebook.com/intern/diff/D76156109/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 6, 2025
…t + reduce stdout logging" ## Changes Some changes to `vulkan_compute_api_test`: * Remove `conv2d_prepack_test`. D74523774 / #11306 recently changed the conv2d prepack shader to use push constants, and since this test uses the "old" vulkan compute API (which doesn't support push constants) the test broke. Operator tests at this point are handled by `compute_graph_op_tests` anyway so just remove this test. * Make it so that verbose logging in `test_to_copy` only occurs in `VULKAN_DEBUG` is defined * Disable `test_etvk_copy_channel_offset_node*` tests, as these tests fail on some platforms (i.e. devGPU, windows, mac) likely due to an error in the implementation of the op. Differential Revision: [D76156109](https://our.internmc.facebook.com/intern/diff/D76156109/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 9, 2025
… compute_api_test + reduce stdout logging" ## Changes Some changes to `vulkan_compute_api_test`: * Remove `conv2d_prepack_test`. D74523774 / #11306 recently changed the conv2d prepack shader to use push constants, and since this test uses the "old" vulkan compute API (which doesn't support push constants) the test broke. Operator tests at this point are handled by `compute_graph_op_tests` anyway so just remove this test. * Make it so that verbose logging in `test_to_copy` only occurs in `VULKAN_DEBUG` is defined * Disable `test_etvk_copy_channel_offset_node*` tests, as these tests fail on some platforms (i.e. devGPU, windows, mac) likely due to an error in the implementation of the op. Differential Revision: [D76156109](https://our.internmc.facebook.com/intern/diff/D76156109/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jun 9, 2025
…t + reduce stdout logging" ## Changes Some changes to `vulkan_compute_api_test`: * Remove `conv2d_prepack_test`. D74523774 / #11306 recently changed the conv2d prepack shader to use push constants, and since this test uses the "old" vulkan compute API (which doesn't support push constants) the test broke. Operator tests at this point are handled by `compute_graph_op_tests` anyway so just remove this test. * Make it so that verbose logging in `test_to_copy` only occurs in `VULKAN_DEBUG` is defined * Disable `test_etvk_copy_channel_offset_node*` tests, as these tests fail on some platforms (i.e. devGPU, windows, mac) likely due to an error in the implementation of the op. Differential Revision: [D76156109](https://our.internmc.facebook.com/intern/diff/D76156109/) [ghstack-poisoned]
SS-JIA
pushed a commit
that referenced
this pull request
Jun 10, 2025
…stdout logging (#11486) ## Changes Some changes to `vulkan_compute_api_test`: * Remove `conv2d_prepack_test`. D74523774 / #11306 recently changed the conv2d prepack shader to use push constants, and since this test uses the "old" vulkan compute API (which doesn't support push constants) the test broke. Operator tests at this point are handled by `compute_graph_op_tests` anyway so just remove this test. * Make it so that verbose logging in `test_to_copy` only occurs in `VULKAN_DEBUG` is defined * Disable `test_etvk_copy_channel_offset_node*` tests, as these tests fail on some platforms (i.e. devGPU, windows, mac) likely due to an error in the implementation of the op. Differential Revision: [D76156109](https://our.internmc.facebook.com/intern/diff/D76156109/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D74523774