Skip to content

Remove the ability to choose pybinding when installing ExecuTorch #11233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 29, 2025

Summary

Fixes #11176

Test plan

CI

rg "\-\-pybind" --hidden -g '!**/{third-party,.git}'

@jathu jathu added ciflow/trunk ciflow/binaries release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 29, 2025
Copy link

pytorch-bot bot commented May 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11233

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit ea9a891 with merge base 9f74777 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2025
@jathu jathu marked this pull request as ready for review May 29, 2025 22:17
Comment on lines +69 to +71
```bash
CMAKE_ARGS="-DEXECUTORCH_BUILD_MPS=ON" ./install_executorch.sh
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I thought we don't provide the option? If we are providing it, why is this better than --pybind mps

Copy link
Contributor Author

@jathu jathu May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to leave this option open mainly for development on new backends. After the MPS changes, I think it would make sense to remove this example from public docs

@jathu jathu force-pushed the jathu/no-pybind-option branch from 9612e63 to ea9a891 Compare May 30, 2025 20:33
@jathu jathu merged commit 66dfc46 into main May 30, 2025
216 of 218 checks passed
@jathu jathu deleted the jathu/no-pybind-option branch May 30, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the option to choose pybindings in install_executorch
3 participants