-
Notifications
You must be signed in to change notification settings - Fork 591
Remove the ability to choose pybinding when installing ExecuTorch #11233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11233
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit ea9a891 with merge base 9f74777 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
```bash | ||
CMAKE_ARGS="-DEXECUTORCH_BUILD_MPS=ON" ./install_executorch.sh | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I thought we don't provide the option? If we are providing it, why is this better than --pybind mps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to leave this option open mainly for development on new backends. After the MPS changes, I think it would make sense to remove this example from public docs
9612e63
to
ea9a891
Compare
Summary
Fixes #11176
Test plan
CI