[ET-VK] Removed shared memory usage and simplied conv2d dw op shader to improve performance. #11178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to improve performance. This diff removes shared memory usage in `conv2d_dw_output_tile.glsl` shader to improve performance. Makes sum a one dimensional array, and moves bias application before storing texel. Differential Revision: [D75499165](https://our.internmc.facebook.com/intern/diff/D75499165/) [ghstack-poisoned]
This was referenced May 28, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11178
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f4fa2c3 with merge base f8a3fd8 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 28, 2025
facebook-github-bot
added
the
CLA Signed
This was referenced May 28, 2025
Merged
trivedivivek
added a commit
that referenced
this pull request
May 28, 2025
…to improve performance. This diff removes shared memory usage in `conv2d_dw_output_tile.glsl` shader to improve performance. Makes sum a one dimensional array, and moves bias application before storing texel. Differential Revision: [D75499165](https://our.internmc.facebook.com/intern/diff/D75499165/) ghstack-source-id: 286577756 Pull Request resolved: #11178
|
This pull request was exported from Phabricator. Differential Revision: D75499165 |
… op shader to improve performance." This diff removes shared memory usage in `conv2d_dw_output_tile.glsl` shader to improve performance. Makes sum a one dimensional array, and moves bias application before storing texel. Differential Revision: [D75499165](https://our.internmc.facebook.com/intern/diff/D75499165/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
May 28, 2025
…to improve performance. Pull Request resolved: #11178 This diff removes shared memory usage in `conv2d_dw_output_tile.glsl` shader to improve performance. Makes sum a one dimensional array, and moves bias application before storing texel. ghstack-source-id: 286585745 @exported-using-ghexport Differential Revision: [D75499165](https://our.internmc.facebook.com/intern/diff/D75499165/)
|
This pull request was exported from Phabricator. Differential Revision: D75499165 |
… op shader to improve performance." This diff removes shared memory usage in `conv2d_dw_output_tile.glsl` shader to improve performance. Makes sum a one dimensional array, and moves bias application before storing texel. Differential Revision: [D75499165](https://our.internmc.facebook.com/intern/diff/D75499165/) [ghstack-poisoned]
trivedivivek
added a commit
that referenced
this pull request
May 28, 2025
…to improve performance. Pull Request resolved: #11178 This diff removes shared memory usage in `conv2d_dw_output_tile.glsl` shader to improve performance. Makes sum a one dimensional array, and moves bias application before storing texel. ghstack-source-id: 286586831 @exported-using-ghexport Differential Revision: [D75499165](https://our.internmc.facebook.com/intern/diff/D75499165/)
|
This pull request was exported from Phabricator. Differential Revision: D75499165 |
jorgep31415
approved these changes
May 30, 2025
… op shader to improve performance." This diff removes shared memory usage in `conv2d_dw_output_tile.glsl` shader to improve performance. Makes sum a one dimensional array, and moves bias application before storing texel. Differential Revision: [D75499165](https://our.internmc.facebook.com/intern/diff/D75499165/) [ghstack-poisoned]
This was referenced May 30, 2025
|
This pull request was exported from Phabricator. Differential Revision: D75499165 |
trivedivivek
added
the
release notes: vulkan
… op shader to improve performance." This diff removes shared memory usage in `conv2d_dw_output_tile.glsl` shader to improve performance. Makes sum a one dimensional array, and moves bias application before storing texel. Differential Revision: [D75499165](https://our.internmc.facebook.com/intern/diff/D75499165/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D75499165 |
facebook-github-bot
merged commit e103333
into
gh/trivedivivek/102/base
96 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
May 31, 2025
…to improve performance. (#11270) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11178 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/102/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/102/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/101/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/102/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff removes shared memory usage in
conv2d_dw_output_tile.glslshader to improve performance.Makes sum a one dimensional array, and moves bias application before storing texel.
Differential Revision: D75499165