Skip to content

[ET-VK] Tuning local workgroup size calculation for conv2d pw to improve performance. #11135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025
Merged

[ET-VK] Tuning local workgroup size calculation for conv2d pw to improve performance. #11135

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0f92a2
[ET-VK] Tuning local workgroup size calculation for conv2d pw to impr…
trivedivivek May 27, 2025
8899cb1
Update on "[ET-VK] Tuning local workgroup size calculation for conv2d…
trivedivivek May 27, 2025
84f5d9c
Update on "[ET-VK] Tuning local workgroup size calculation for conv2d…
trivedivivek May 27, 2025
02ba09f
Update on "[ET-VK] Tuning local workgroup size calculation for conv2d…
trivedivivek May 28, 2025
8b1b647
Update on "[ET-VK] Tuning local workgroup size calculation for conv2d…
trivedivivek May 28, 2025
ea2e9d5
Update on "[ET-VK] Tuning local workgroup size calculation for conv2d…
trivedivivek May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion backends/vulkan/runtime/graph/ops/impl/Convolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,21 @@ void add_conv2d_node(
wg_size = {wg_size[0] * wg_size[1], wg_size[2], 1};
}

utils::uvec3 local_wg_size;
if (method == Conv2dMethod::Pointwise) {
uint32_t local_wg_size_y = 1;
if (wg_size[1] % 8 == 0) {
local_wg_size_y = 8;
} else if (wg_size[1] % 4 == 0) {
local_wg_size_y = 4;
} else if (wg_size[1] % 2 == 0) {
local_wg_size_y = 2;
}
local_wg_size = {64 / local_wg_size_y, local_wg_size_y, 1};
} else {
local_wg_size = graph.create_local_wg_size(wg_size);
}

vkapi::ParamsBindList param_buffers;
std::vector<PushConstantDataInfo> push_constants;
if (method == Conv2dMethod::Pointwise) {
Expand Down Expand Up @@ -464,7 +479,7 @@ void add_conv2d_node(
graph,
shader,
wg_size,
graph.create_local_wg_size(wg_size),
local_wg_size,
// Inputs and Outputs
{{out, vkapi::kWrite}, {{in, arg_weight, arg_bias}, vkapi::kRead}},
// Shader params buffers
Expand Down
Loading