Skip to content

Add portable randn kernel implementation #11123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

Add portable randn kernel implementation #11123

merged 1 commit into from
May 31, 2025

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented May 24, 2025 •
edited by pytorch-bot bot
Loading

Summary

Add a portable operator implementation for ATen randn. This is a core op that we previously have not had a kernel for.

Test plan

I've added operator-level tests for randn. It's relatively sparse, but validates that the mean and stdev are reasonably sane, as well as that the operator functions correctly for different dtypes, ranks, and sizes.

cc @larryliu0820 @manuelcandales

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11123

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1b3b295 with merge base 809a1fd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 24, 2025
@GregoryComer GregoryComer added the module: kernels Issues related to kernel libraries and utilities, and code under kernels/ label May 24, 2025
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GregoryComer GregoryComer added release notes: ops & kernels Changes to the opset and any new / changed kernel implementations and removed module: kernels Issues related to kernel libraries and utilities, and code under kernels/ labels May 24, 2025
@GregoryComer GregoryComer force-pushed the portable-randn branch 2 times, most recently from afb218a to 8a48eb1 Compare May 24, 2025 05:11
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GregoryComer GregoryComer merged commit 70f1456 into pytorch:main May 31, 2025
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@jathu jathu Awaiting requested review from jathu jathu is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GregoryComer @facebook-github-bot @manuelcandales