Skip to content

Qualcomm AI Engine Direct - GA DIT #11093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

shewu-quic
Copy link
Collaborator

Summary:

  • Add DIT example script
    • Use HistogramObserver as act_observer to resolve accuracy issue
  • Add the test for DIT
  • Support UpsampleBicubic
    • Remove unused pass convert_upsample_bicubic2d.py

@shewu-quic shewu-quic requested a review from cccclai as a code owner May 23, 2025 04:41
Copy link

pytorch-bot bot commented May 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11093

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4789975 with merge base 95a1db5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2025
@shewu-quic shewu-quic force-pushed the dev1/hutton/ga_dit branch 2 times, most recently from 0b90e3d to 13a4a50 Compare May 23, 2025 07:37
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how do you know Histogram observer can resolve the accuracy issue?

@shewu-quic
Copy link
Collaborator Author

Curious how do you know Histogram observer can resolve the accuracy issue?

In the begining, I observe the scale of some nodes is bigger than 0.1 with MinMaxObserver. Therefore, I try to use other observer to resolve accuracy issue. When I try Histogram observer, it seems to get reasonable accuracy.

Summary:
- Add DIT example script
  - Use HistogramObserver as act_observer to resolve accuracy issue
- Add the test for DIT
- Support UpsampleBicubic
  - Remove unused pass convert_upsample_bicubic2d.py
@shewu-quic shewu-quic force-pushed the dev1/hutton/ga_dit branch from 13a4a50 to 4789975 Compare June 2, 2025 02:39
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai added the release notes: qualcomm Changes to the Qualcomm backend delegate label Jun 5, 2025
@cccclai cccclai merged commit 36a3207 into pytorch:main Jun 5, 2025
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants