IOManager Interface #10418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

JacobSzwejbka wants to merge 1 commit into pytorch:main from JacobSzwejbka:export-D73450877

Contributor

JacobSzwejbka commented Apr 23, 2025 •

edited by pytorch-bot bot

Loading

Summary:
Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

cc @larryliu0820 @mergennachin @cccclai @helunwencser @jackzhxng

JacobSzwejbka requested review from jackzhxng, iseeyuan, larryliu0820 and swolchok as code owners

April 23, 2025 22:47

pytorch-bot bot commented Apr 23, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10418

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 65d3eac with merge base d5fe5fa ():

NEW FAILURE - The following job has failed:

pull / unittest / macos / macos-job (gh)
The process '/usr/bin/git' failed with exit code 128

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / linux / linux-job (gh) (trunk failure)
examples/models/llama/tests/test_ring_attention.py::TestRingAttention::test_sliding_window_attention_custom
pull / unittest-editable / linux / linux-job (gh) (trunk failure)
examples/models/llama/tests/test_ring_attention.py::TestRingAttention::test_sliding_window_attention_custom

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Apr 23, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

facebook-github-bot added the fb-exported label

JacobSzwejbka force-pushed the export-D73450877 branch from 934cad4 to ecc2362 Compare

April 29, 2025 19:38

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

ecc2362

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

Contributor

facebook-github-bot commented Apr 29, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from ecc2362 to bf3ac0b Compare

April 29, 2025 19:42

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

f5b9dbd

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from bf3ac0b to f5b9dbd Compare

April 29, 2025 19:47

Contributor

facebook-github-bot commented Apr 29, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added module: llm release notes: api labels

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

37d4964

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from f5b9dbd to 37d4964 Compare

April 29, 2025 20:03

Contributor

facebook-github-bot commented Apr 29, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from 37d4964 to aea5220 Compare

May 5, 2025 17:29

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

aea5220

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

Contributor

facebook-github-bot commented May 5, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

13a543a

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from aea5220 to 13a543a Compare

May 5, 2025 17:39

Contributor

facebook-github-bot commented May 5, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

1b3b148

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from 13a543a to 1b3b148 Compare

May 5, 2025 17:57

Contributor

facebook-github-bot commented May 5, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

afca5e8

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from 1b3b148 to afca5e8 Compare

May 5, 2025 18:00

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

2d2ba9c

Summary:
Pull Request resolved: pytorch#10418

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from afca5e8 to 2d2ba9c Compare

May 5, 2025 18:00

Contributor

facebook-github-bot commented May 5, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from 2d2ba9c to 7abb2d8 Compare

May 5, 2025 20:26

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

7abb2d8

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

Contributor

facebook-github-bot commented May 5, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

eb2e374

Summary:
Pull Request resolved: pytorch#10418

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from 7abb2d8 to eb2e374 Compare

May 5, 2025 20:29

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

faaecc8

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from eb2e374 to faaecc8 Compare

June 24, 2025 19:35

JacobSzwejbka requested a review from mergennachin as a code owner

June 24, 2025 19:35


          IOManager Interface (pytorch#10418)

65d3eac

Summary:
Pull Request resolved: pytorch#10418

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request


          IOManager Interface (pytorch#10418)

1a99906

Summary:

Hopefully this is sufficient for the contract.

Going to do 2 follow up tests.

Add a basic cpu implementation

add a static attention implementation.

Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from faaecc8 to 1a99906 Compare

June 24, 2025 19:38

Contributor

facebook-github-bot commented Jun 24, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

1 similar comment

Contributor

facebook-github-bot commented Jun 24, 2025

This pull request was exported from Phabricator. Differential Revision: D73450877

JacobSzwejbka force-pushed the export-D73450877 branch from 1a99906 to 65d3eac Compare

June 24, 2025 19:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

iseeyuan Awaiting requested review from iseeyuan

larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

swolchok Awaiting requested review from swolchok swolchok is a code owner

mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Labels

CLA Signed fb-exported module: llm release notes: api