Skip to content

Update QAT docs, highlight axolotl integration #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SalmanMohammadi
Copy link
Contributor

We've recently landed support for QAT and PTQ with ao in axolotl (axolotl-ai-cloud/axolotl#2590). Thanks again to @andrewor14 for helping out here.

This PR updates the QAT readme following the discussion in this PR. I would also be very grateful if you would allow us to showcase the integration of ao into axolotl in your OSS integrations section.

Copy link

pytorch-bot bot commented May 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2266

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 14cc86d with merge base 63f2e51 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2025
@jerryzh168 jerryzh168 requested a review from andrewor14 May 28, 2025 17:57
Copy link
Contributor

@andrewor14 andrewor14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SalmanMohammadi! Very excited to see this new integration!

@@ -115,11 +115,20 @@ To fake quantize embedding in addition to linear, you can additionally call
the following with a filter function during the prepare step:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a section below that says "torchtune integration". Can you add a similar section for "Axolotl Integration" and add a small code snippet there?

@andrewor14 andrewor14 added the topic: documentation Use this tag if this PR adds or improves documentation label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: documentation Use this tag if this PR adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants