Skip to content

Try fixing CI by pinning pytest #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Try fixing CI by pinning pytest #2238

merged 2 commits into from
May 22, 2025

Conversation

atalman
Copy link
Contributor

@atalman atalman commented May 22, 2025

Looks like pytest is failing with Segfault even when I execute simple pytest --version

exec: line 14:   238 Segmentation fault      (core dumped) python -u -m pytest --version

Hence Pinning the pytest to previous version fixes the Segfault

Test PR: #2237
Failure: https://github.com/pytorch/ao/actions/runs/15176248032/job/42676994119?pr=2237#step:15:1427

We would probably need to followup on this to understand why this have happended, since latest pytest update was March 2, 2025: https://pypi.org/project/pytest/8.3.5/

Copy link

pytorch-bot bot commented May 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2238

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9139b4a with merge base 5153bd3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2025
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label May 22, 2025
@drisspg
Copy link
Contributor

drisspg commented May 22, 2025

Is this saying that the regression test requries 7.4 but main is on 8.3?

Also great job finding this!

@atalman atalman merged commit f0f976c into main May 22, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants