Skip to content

AOT plugin: examples with RMSNORM #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

AOT plugin: examples with RMSNORM #3529

wants to merge 1 commit into from

Conversation

bowang007
Copy link
Collaborator

Description

This PR includes the AOT Plugin demo for RMSNorm Triton kernel.

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

return output


@trtp.register("flashinfer::rmsnorm")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant this just be torch_tensorrt.dynamo.conversion.custom_op?

# # As long as the namespace and names match, the following function will automatically generate the converter for the operation.


torch_tensorrt.dynamo.conversion.plugins.generate_plugin_converter(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesnt custom op handle this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants