AOT plugin: examples with RMSNORM #3529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narendasan
reviewed
May 22, 2025
| return output | ||
|
|
||
|
|
||
| @trtp.register("flashinfer::rmsnorm") |
There was a problem hiding this comment.
cant this just be torch_tensorrt.dynamo.conversion.custom_op?
narendasan
reviewed
May 22, 2025
| # # As long as the namespace and names match, the following function will automatically generate the converter for the operation. | ||
|
|
||
|
|
||
| torch_tensorrt.dynamo.conversion.plugins.generate_plugin_converter( |
There was a problem hiding this comment.
Doesnt custom op handle this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the AOT Plugin demo for RMSNorm Triton kernel.
Checklist: