Pass --warmup along to pyperf #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
reviewed
Jun 22, 2025
| @@ -247,5 +247,7 @@ def get_pyperf_opts(options): | |||
| if options.hook: | |||
| for hook in options.hook: | |||
| opts.append('--hook=%s' % hook) | |||
| if options.warmups is not None: | |||
There was a problem hiding this comment.
Suggested change
| if options.warmups is not None: | |
| if options.warmups: |
There was a problem hiding this comment.
We also need to be able to pass --warmups 0 explicitly when that is specified.
There was a problem hiding this comment.
Can you leave the comment for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running pystats collection, it is useful to /not/ do warmup runs so we don't "miss" any of the stats. This requires being able pass the
--warmupsargument to the underlying pyperf.