-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-132962: _pyrepl: Prevent crash on Windows when stdout is redirected #135456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shuimu5418
wants to merge
17
commits into
python:main
Choose a base branch
from
shuimu5418:fix-gh-132962-win-repl-redirect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
93c04f9
gh-132962: _pyrepl: Prevent crash on Windows when stdout is redirected
shuimu5418 d8cc913
Add a test case to test_windows_console.py
shuimu5418 2e945fe
Replace sleep() with timeout in test case
shuimu5418 459232d
Fix formatting errors and make it pass CI tests
shuimu5418 7a8778d
gh-135371: Fix asyncio introspection output to include internal corou…
pablogsal 67d3adc
gh-135504: Document `LIBZSTD_CFLAGS` and `LIBZSTD_LIBS` config option…
sobolevn df6e5b3
gh-135497: fix `MAXLOGNAME` detection in `configure.ac` (#135508)
alebcay 73b6ea2
gh-135171: Update documentation for the generator expression (GH-135351)
serhiy-storchaka 67c853f
gh-127319: Disable port reuse on HTTP, XMLRPC, and logging TCP server…
jeremycline 2e71605
gh-65697: Improved error msg for configparser key validation (#135527)
lincolnj1 017aeab
gh-135371: Clean tags from pointers in all cases in remote debugging …
pablogsal e170848
gh-135361: update documentation for `remote_debugger_script` audit ev…
Zheaoli 34e85c3
gh-111178: fix UBSan failures for `RemoteUnwinderObject` (#135539)
picnixz c4c7a98
gh-67022: Document bytes/str inconsistency in email.header.decode_hea…
dlenski 062a483
Fix test
shuimu5418 3ae08fa
Fix CI
shuimu5418 fbcc6b1
Merge branch 'main' into fix-gh-132962-win-repl-redirect
shuimu5418 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Windows/2025-06-13-19-18-00.gh-issue-132962.qOquLB.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
The interactive interpreter (-i) on Windows no longer crashes when standard | ||
output is redirected. It now correctly falls back to the basic REPL in this | ||
situation. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said earlier, we should avoid exercising the bug, and instead exercise the correct behavior. There's no need for explicit detection of the infinite traceback.
We should just call
process.wait()
without a timeout, and then assert thatscript has run
is in the stdout.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used the -i parameter, so if proc.wait() is called, Python will wait forever. There's not much I can do about this. However, exercising the correct behavior is absolutely possible. Thanks.