Skip to content

Conversation

@mhaxanali
Copy link
Contributor

Relevant Issues

Closes #1450

Description

Added on_raw_reaction_add handler to support reaction events in DMs, as the standard on_reaction_add doesn't fire in DM contexts.

Original Implementation @ OSCxSST/sir-lancebot-SLB/pull/20

I Did:

@Akarys42
Copy link
Contributor

As it stands currently, considering you have both on_raw_reaction_add and on_reaction_add, wouldn't the action be performed twice if the message is inside a guild?

@mhaxanali
Copy link
Contributor Author

As it stands currently, considering you have both on_raw_reaction_add and on_reaction_add, wouldn't the action be performed twice if the message is inside a guild?

Yes, I just tested that, and I think on_reaction_add should be removed then. Also the try-except block removed previously for deleted reactions needs to be added again for this change, which I have done. Few imports also became unused after this change so removing them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trashcan delete reaction does not work in DMs

3 participants