fix: handle pytest.exit gracefully instead of INTERNALERROR#1358
Closed
fazalpsinfo-cmyk wants to merge 1 commit into
Closed
fix: handle pytest.exit gracefully instead of INTERNALERROR#1358fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
When pytest.exit() is called mid-test, the worker finishes with a pending test (crashitem). The controller's worker_workerfinished asserted not crashitem, turning an intentional exit into an INTERNALERROR. Replace the assertion with graceful handle_crashitem, matching the pattern used in worker_internal_error. Closes pytest-dev#1239
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
pytest.exit()is called mid-test, the worker finishes with a pending test (crashitem). The controller'sworker_workerfinishedassertednot crashitem, turning an intentional exit into an INTERNALERROR.Replaced the assertion with graceful
handle_crashitem, matching the pattern already used inworker_internal_error.Closes #1239
Support my open source work: https://buymeacoffee.com/muhamedfazalps