feat: Add Celluloid support (with ani-skip)

[Vvamp]

Type of change

• Bug fix
• Feature
• Documentation update

Description

Celluloid is a popular MPV frontend. Since celluloid can pass mpv arguments by using a 'mpv-' prefix in the command args, I figured it'd be easy to add. It just uses mpv on the backend after all.

I opted for not adding a new case in the switch, but instead adding the "celluloid" pattern in the mpv option. I then added an optional prefix, which is set if the player is celluloid. It could be done as a seperate option, but I wanted to prevent duplicate code.

I bumped the version to 4.10.0 as I noticed that is what you guys were aiming for in the next release. I checked 'range selection' as working, as you guys are already aware of the pre-existing bug with range selection and it's not related to this PR. The readme and help still mention that --skip only works with mpv, but since celluloid is still just mpv, I thought it was still correct.

Note: To make this work the user would have to copy ani-skip's skip.lua to the scripts folder under ~/.config/celluloid/scripts/ instead of ~/.config/mpv/scripts/.

Checklist

• any anime playing
• bumped version

---

• next, prev and replay work
• -c history and continue work
• -d downloads work
• -s syncplay works
• -q quality works
• -v vlc works
• -e select episode works
• -S select index works
• -r range selection works
• --skip ani-skip works
• --skip-title ani-skip title argument works
• --no-detach no detach works
• --dub and regular (sub) mode both work
• all providers return links (not necessarily on a single anime, use debug mode to confirm)

---

• -h help info is up to date
• Readme is up to date
• Man page is up to date

[Derisis13]

Thanks for the dettailed explanation and thoughtful implementation.
I'd like to see the readme and the manpage updated to reflect the new capability.
Also please iron out that one shellcheck complaint you seem to have missed.

Then I'll test it myself too, and see if it works. Merging may have to wait until 4.10 is merged too, but maybe we can include the feature in the release.

[Vvamp]

Thanks for the quick reply.
I added the capabilities to the README, help and manpage, as well as a small note to the README's ani-skip section to explain how to get ani-skip to work with celluloid. Let me know if you need me to make any other adjustments.

[port19x]

Code looks good, elegant flag normalisation

[port19x]

Doesn't this belong in the ani-skip documentation instead?

[port19x]

No detach with celluloid is kinda stupid since its a gui program.
--no-detach was meant for in terminal playback

[port19x]

Note that I removed your manpage notice that --exit-after-play only works with --no-detach, since the flag --exit-after-play internally enables --no-detach anyway

[Derisis13]

Just a minor warning: some distros (Fedora) like to package celluloid (like mpv) with URL playback disabled. Maybe it'd be worth noting in the readme.

[port19x]

Just a minor warning: some distros (Fedora) like to package celluloid (like mpv) with URL playback disabled. Maybe it'd be worth noting in the readme.

We should definitely note that down somewhere, or even just make a dummy issue that is easily discoverable so anyone running into the issue can be referred to it