fix(upgrade): emit dash bullets in changelog#3182
Merged
Merged
Conversation
_write_changelog rendered list items with ``*``, but the repo's docstrfmt pre-commit hook normalizes bullet lists to ``-``. Every auto-generated upgrade PR therefore failed docstrfmt until fixed by hand (see #3180). Emit ``-`` so the fragment is clean on the first try.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_write_changelogintasks/upgrade_wheels.pyrendered upgrade list items with*, but the repo'sdocstrfmtpre-commit hook normalizes bullet lists to-. Every auto-generated upgrade PR failed docstrfmt until the bullet was fixed by hand (e.g. #3180).Emit
-so the generated fragment is clean on the first try.Task-script-only change, so no changelog fragment (matches #3143).