Add User-Agent header with Hatch, Python and HTTPX versions #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjames23
reviewed
Nov 25, 2025
Member
cjames23
left a comment
cjames23
left a comment
There was a problem hiding this comment.
Thanks for providing this! Can you adjust tests to confirm headers as a test to avoid regressions in the future?
Contributor
Author
|
Yes, added, how's this? |
ofek
approved these changes
Nov 26, 2025
|
|
||
| user_agent = ( | ||
| f"Hatch/{__version__} " | ||
| f"{platform.python_implementation()}/{platform.python_version()} " |
Contributor
There was a problem hiding this comment.
Out of curiosity, can we achieve the same with sys or somehow not use platform? This is purely theoretical as it wouldn't matter when we're doing something heavy already like making network requests.
❯ python -m timeit -n 1 -r 1 "import platform"
1 loop, best of 1: 5.52 msec per loop
Member
There was a problem hiding this comment.
It can be done with sys.implementation.name and sys.implementation.version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1816.
Add a User-Agent header such as:
Hatch/1.12.1.dev42 CPython/3.12.7 HTTPX/0.27.2