spawn: don't force param cmd to be mutable
#390
+92
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
def-spawn-better-types
branch
from
1e73a19 to
22f61d9
Compare
Contributor
Author
|
Avasam
commented
Dec 20, 2025
| # function) -- authors of new compiler interface classes are | ||
| # responsible for updating 'compiler_class'! | ||
| compiler_type: ClassVar[str] = None # type: ignore[assignment] | ||
| compiler_type: ClassVar[str] = None |
Contributor
Author
There was a problem hiding this comment.
Will be added back in #368 , but tests currently fails with this due to unused type-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has 2 advantages:
cmddoesn't have to be mutable. Sotuplesare usableMutableSequenceis invariant. which can cause issues with union types since you need to match the exact full union type (some checkers do allow partial union match for inline/literal sequences)I also improved the possible param types by using an overload on
search_path(sincesearch_pathallowsbytes | str | PathLike[str], but notPathLike[bytes])Open question: Since
verboseisn't used inspawn, maybe it's better to not even expose it as a possible kwargs inCompilerclasses ? (no runtime change, just hiding it from the type annotation in wrapper methods)