Skip to content

transaction: add number of retries attempted to return calls #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

mdeneen
Copy link
Contributor

@mdeneen mdeneen commented May 22, 2025

If a transaction is successfully processed, return result along with the number of retries. This can be useful for application layer logic which may want to know that retries are happening.

If a transaction is successfully processed, return result along with the number of retries.  This can be useful for application layer logic which may want to know that retries are happening.
@mdeneen
Copy link
Contributor Author

mdeneen commented May 22, 2025

Ah, I see that I need to adjust the return types. Give me a few minutes.

@mdeneen
Copy link
Contributor Author

mdeneen commented May 22, 2025

Can you offer some guidance on the python typing? I think that you will understand what I am going for here.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really breaks a lot, as you can see in the CI run.

We do not want to return a tuple, because it would be a lot easier just to add a field in the response, with the added benefit that it is backwards compatible.

@mdeneen
Copy link
Contributor Author

mdeneen commented May 22, 2025

I see that this will impact existing code too much, so I am going to close this request.

@mdeneen mdeneen closed this May 22, 2025
@mdeneen
Copy link
Contributor Author

mdeneen commented May 22, 2025

Hey, Jan, I will look at adding it to the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants