Skip to content

Update CONTRIBUTING.md #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bcfletcher
Copy link

added language about installing node-canvas

added language about installing node-canvas
@dlech
Copy link
Member

dlech commented Mar 24, 2025

Why do we need to install this manually?

@bcfletcher
Copy link
Author

I'm a Mac so homebrew isn't installed by default. Nor are any of the requirements to build and compile pybricks.

It took me a while to figure out all the areas to get it to build.

@dlech
Copy link
Member

dlech commented Mar 24, 2025

I'm just a bit confused why we need node-canvas though. We don't have to install it on CI to build or test, so why do we have to install it locally?

@bcfletcher
Copy link
Author

bcfletcher commented Mar 24, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants