Allow customization of output targets in script/electron-builder.js…
#1397
+52
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at least on Linux and Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at least on Linux and Windows.
The documentation already thinks this is possible! (Select the “Linux” tab if you're not on Linux.) The script doesn't support this, but it ought to — especially on Linux, since building an AppImage is time-intensive. Better to change the code here than to change the docs.
We can control targets on Windows as well, so we might as well let them in on the fun and allow (e.g.)
yarn dist nsisto opt into just the NSIS build and skip the portable target. (The current docs sayyarn dist portableshould be possible, butelectron-buildercalls this targetzip, so I decided to keep it simple. Happy to keep it asportableif people prefer.)If a user specifies targets that don't match their current platform, they will be ignored. Default behavior has not changed; if no applicable targets are provided, then the whole list of them should be generated.
Feel free to test this for your specific platform; I did sanity checking on Linux, but I didn't try to run each individual option in isolation.