Remove reliance on title key of a setting to avoid using locale labels
#1391
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was brought to my attention on Discord that when using the settings search if a setting appears that has a title key as a
LocaleLabelit isn't translated.This PR removes our intention to always trust the title key and instead always rely on the
rich-title.jsutility. Which itself will already try to use thetitlekey if present, and supports translation of the keys in any case.