Skip to content

Conversation

@confused-Techie
Copy link
Member

It was brought to my attention on Discord that when using the settings search if a setting appears that has a title key as a LocaleLabel it isn't translated.

This PR removes our intention to always trust the title key and instead always rely on the rich-title.js utility. Which itself will already try to use the title key if present, and supports translation of the keys in any case.

@savetheclocktower
Copy link
Contributor

Now that I'm thinking about it: which value gets consulted when searching for the name of a setting? I doubt the localized setting is considered (which is fine for now), but does it search the default display name of the setting?

@confused-Techie
Copy link
Member Author

@savetheclocktower Good thought on search, the search will try to match against the LocaleLabel currently, although a saving grace is it also considers:

  • Title (the normal title or it could be the localeLabel)
  • Description
  • The setting key, which is what the title is generated from whenever the title key isn't defined, which as you know is often)
  • The parent key to that settings key, commonly the package name or namespace of the setting.

We absolutely will likely want to first localize these labels before searching, although I don't have the chance right now. If curious here's the source for this logic.

@confused-Techie confused-Techie merged commit 4803eeb into master Dec 20, 2025
102 of 103 checks passed
@confused-Techie confused-Techie deleted the confused-Techie-patch-1 branch December 20, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants