Skip to content

Conversation

@savetheclocktower
Copy link
Contributor

We've finally got a Tree-sitter fix for the next version, whenever it may be!

Someone reported a bug against my tree-sitter-scss parser, so I fixed it and updated the parser in language-sass. I also added a grammar test for the issue. (More stuff should go in there, but I'm lazy now, and at least the infrastructure is present to add further grammar tests later.)

…where `color:red;` was interpreted as a tag and pseudoclass instead of a property-value pair.
…plus the names of abstract methods in class definitions.
Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust this is right, I don't have a ton of context about the language features these changes are about, but... not in a mood to block it! Kind of a rubber-stamp, but I have read diffs and commit messages to know nominally what I'm approving, at least!

Glanced at the diff of tree-sitter-scss too, but that one is rather big!

@DeeDeeG
Copy link
Member

DeeDeeG commented Jul 21, 2025

Build (CI) fix should be in master now as of #1309 so I'm not worried about that -- (I'd presume Linux testing should be fine?).

@savetheclocktower
Copy link
Contributor Author

Glanced at the diff of tree-sitter-scss too, but that one is rather big!

Yeah, lots of generated files with a Tree-sitter parser change. The changes to grammar.js and/or scanner.c are the only ones that are hand-authored. (Plus the corpus additions.)

@DeeDeeG
Copy link
Member

DeeDeeG commented Jul 21, 2025

Nice, at least those are pretty compact changes. (I of course appreciate specs being added.)

@savetheclocktower
Copy link
Contributor Author

(the full change, for posterity)

@savetheclocktower savetheclocktower merged commit 32ce970 into master Jul 21, 2025
198 of 200 checks passed
@savetheclocktower savetheclocktower deleted the tree-sitter-1-129 branch July 21, 2025 20:42
savetheclocktower added a commit that referenced this pull request Oct 12, 2025
* Fix a bug in `tree-sitter-scss`…

…where `color:red;` was interpreted as a tag and pseudoclass instead of a property-value pair.

* [language-sass] Add grammar spec for fixed issue in `tree-sitter-scss`

* [language-typescript] Highlight `abstract` modifier properly…

…plus the names of abstract methods in class definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants